Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for new strategies #7084

Merged
merged 3 commits into from
May 31, 2023
Merged

Fixes for new strategies #7084

merged 3 commits into from
May 31, 2023

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented May 31, 2023 •
edited

  • Improve DockerDesktopClientProviderStrategy description
  • Fix TestcontainersHostPropertyClientProviderStrategy only when tc.host is present

Fixes #7082

@eddumelendez eddumelendez requested a review from a team as a code owner May 31, 2023 11:27
@eddumelendez eddumelendez merged commit 2b70b6f into 1.18.x May 31, 2023
79 checks passed
@eddumelendez eddumelendez deleted the fix_tchost_strategy branch May 31, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddumelendez @kiview