Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read from both /proc/net/tcp and /proc/net/tcp6 in InternalCommandPortListeningCheck #750

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Read from both /proc/net/tcp and /proc/net/tcp6 in InternalCommandPortListeningCheck #750

merged 1 commit into from
Jun 13, 2018

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Jun 13, 2018 •
edited
Loading

See #749

@bsideup bsideup requested review from rnorth and kiview June 13, 2018 16:15
@bsideup bsideup changed the title Read from both /proc/net/tcp and /proc/net/tcp6 in `InternalComma… Read from both /proc/net/tcp and /proc/net/tcp6 in InternalCommandPortListeningCheck Jun 13, 2018
@rnorth
Copy link
Member

rnorth commented Jun 13, 2018

LGTM, just needs a change log entry?
Thanks for being on this so quickly

@bsideup
Copy link
Member Author

bsideup commented Jun 13, 2018

@rnorth check Slack :D

@bsideup bsideup added this to the next milestone Jun 13, 2018
@bsideup bsideup merged commit cf72d08 into master Jun 13, 2018
@bsideup bsideup deleted the ipv6_in_internal_command_port_check branch September 23, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsideup @rnorth