Ensure that nginx test waits properly to reduce flakiness #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
force-pushed
the
reduce-nginx-test-flakiness
branch
from
78cf9de
to
8541d62
Compare
bsideup
approved these changes
Aug 6, 2018
|
We have this out in a Release Candidate build (1.9.0-rc1) for anyone who is keen to try it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx container tests have been surprisingly flaky for a while, so I had a look into it.
It turns out that the
WaitStrategyin the test has actually been skipping for some time with the warningNo exposed ports or mapped ports - cannot wait for status.I found that the
getLivenessCheckPortsmethod inNginxContaineris implemented incorrectly - rather than producing a HashSet with the liveness check port number as a single member, it produces a HashSet of capacity equal to the port number. This is obviously silly 😂This change fixes that behaviour, and also switches
SimpleNginxTestto use the non-deprecatedHttpWaitStrategyclass.