CouchbaseContainer fixes #830
Conversation
|
will rebase when #829 is merged. |
| @@ -67,12 +61,11 @@ | |||
| @AllArgsConstructor | |||
| public class CouchbaseContainer extends GenericContainer<CouchbaseContainer> { | |||
|
|
|||
| public static final String VERSION = "5.1.0"; | |||
| public static final String VERSION = "5.1.1"; | |||
There was a problem hiding this comment.
any reason we stick to 5.1.1 here? 5.5.0 is out. Is there a reason it is not using latest if not otherwise specified explicitly by the user?
There was a problem hiding this comment.
api compatibility. But this release will have breaking changes anyway for couchbase containers, so why not
| @@ -392,6 +358,11 @@ public CouchbaseContainer withIndexMemoryQuota(String indexMemoryQuota) { | |||
| return self(); | |||
| } | |||
|
|
|||
| public CouchbaseContainer withClusterUsername(String clusterUsername) { | |||
There was a problem hiding this comment.
I wonder if this should be withAdminUsername / withAdminPassword ? to distinguish it from real RBAC users
There was a problem hiding this comment.
I like the word cluster for this context. it allows me to manage the whole thing.
There was a problem hiding this comment.
what about ClusterAdmin ? makes both the scope and the role clear.
| @@ -1,94 +0,0 @@ | |||
| package org.testcontainers.containers; | |||
There was a problem hiding this comment.
there are a lot of changes coming from @bsideup's pr
klara-l
force-pushed
the
bugfix/couchbaseCapiPort
branch
from
d410297
to
5574a89
Compare
- removed example buckets - added withClusterAdmin method - fixed capi port mapping: the environment patching was removed from the couchbase docker container. couchbase/docker@86e665b#diff-8941c93c7af57eff48058be15eb5ecff - updated container from 5.1.0 to 5.5.1
klara-l
force-pushed
the
bugfix/couchbaseCapiPort
branch
from
5574a89
to
835bbd3
Compare
|
We have this out in a Release Candidate build (1.9.0-rc1) for anyone who is keen to try it! |
the environment patching was removed from the couchbase docker container.
couchbase/docker@86e665b#diff-8941c93c7af57eff48058be15eb5ecff