Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused charset constant in GenericContainer #8304

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove unused charset constant in GenericContainer #8304

merged 1 commit into from
Feb 12, 2024

Conversation

dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Feb 12, 2024 •
edited
Loading

Hi,

originally I stumbled upon this because I wanted to change Charset.forName("UTF-8") to StandardCharsets.UTF_8 but it seems the constant is not used at all anymore.

Cheers,
Christoph

@dreis2211 dreis2211 requested a review from a team as a code owner February 12, 2024 19:19
@eddumelendez eddumelendez added this to the next milestone Feb 12, 2024
@eddumelendez eddumelendez merged commit a69750c into testcontainers:main Feb 12, 2024
89 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @dreis2211 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
1.19.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dreis2211 @eddumelendez