Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip starting zookeeper when using a Kafka container with the provided Zookeeper #8433

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Skip starting zookeeper when using a Kafka container with the provided Zookeeper #8433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,14 @@ protected void containerIsStarting(InspectContainerResponse containerInfo) {
// exporting KAFKA_ADVERTISED_LISTENERS with the container hostname
command += String.format("export KAFKA_ADVERTISED_LISTENERS=%s\n", kafkaAdvertisedListeners);

if (this.kraftEnabled && isLessThanCP740()) {
if (!this.kraftEnabled || isLessThanCP740()) {
// Optimization: skip the checks
command += "echo '' > /etc/confluent/docker/ensure \n";
command += commandKraft();
}

if (!this.kraftEnabled) {
eddumelendez marked this conversation as resolved.
Show resolved Hide resolved
// Optimization: skip the checks
command += "echo '' > /etc/confluent/docker/ensure \n";
if (this.kraftEnabled) {
command += commandKraft();
} else if (this.externalZookeeperConnect == null) {
command += commandZookeeper();
}

Expand Down