Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass env to ComposeDelegate in DockerComposeContainer#stop #8493

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Pass env to ComposeDelegate in DockerComposeContainer#stop #8493

merged 4 commits into from
Mar 29, 2024

Commits on Mar 27, 2024

  1. Pass env to ComposeDelegate in DockerComposeContainer#stop 

    This fixes issues on stopping when ENV-Variables are used inside the compose file.
Issue was introduced in 7112db5.

Fixes testcontainers#8492

Signed-off-by: Michael Musenbrock <michael.musenbrock@gmail.com>
    @mmusenbr
    mmusenbr committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e8bfac2 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Pass env to ComposeDelegate in ComposeContainer#stop 

    This is the same change as in DockerComposeContainer, even though
no error is reported here, because COMPOSE_PROJECT_NAME seems sufficient

Signed-off-by: Michael Musenbrock <michael.musenbrock@gmail.com>
    @mmusenbr
    mmusenbr committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9069def View commit details
    Browse the repository at this point in the history

  2. Add tests for env replacement in port definition in compose file 

    Signed-off-by: Michael Musenbrock <michael.musenbrock@gmail.com>
    @mmusenbr
    mmusenbr committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cef1235 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Apply suggestions from code review

    @eddumelendez
    eddumelendez committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    213056b View commit details
    Browse the repository at this point in the history