Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Postgis to JDBC driver #864

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Add support for Postgis to JDBC driver #864

merged 2 commits into from
Sep 13, 2018

Conversation

kiview
Copy link
Member

@kiview kiview commented Sep 11, 2018

This is an alternative implementation of #708, relying completely on the existing PostgreSQLContainer class.

package org.testcontainers.containers;

/**
* Factory for PostGIS containers, which are a special flavour os PostgreSQL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo os -> of

@wimdeblauwe
Copy link
Contributor

Look ok for me, except for the typo remark I made on the PostgisContainerProvider.java file

@kiview
Copy link
Member Author

kiview commented Sep 11, 2018

Cool, so this would work for your use case?

@rnorth WDYT, does it provide value to the project?
As mentioned in the other PR, for normal instantiation, it's fine to use PostgreSQLContainer with constructor argument.

@wimdeblauwe
Copy link
Contributor

wimdeblauwe commented Sep 11, 2018

My use case is an integration test with Spring Boot. For this, I specify:

spring.datasource.url=jdbc:tc:postgis:10://localhost/mydb

in application-integration-test.properties with @ActiveProfiles("integration-test"). If that URL will trigger testcontainers to start the proper postgis image, then it should work.

@kiview
Copy link
Member Author

kiview commented Sep 11, 2018

Yes, it will exactly support those kind of use cases.
I'll wait for feedback from @rnorth and then we can merge, thanks for your input and contributions @wimdeblauwe 🙂

@bsideup bsideup added this to the next milestone Sep 12, 2018
@kiview kiview merged commit 1d0140a into master Sep 13, 2018
@kiview kiview deleted the postgis-jdbc branch September 13, 2018 07:28
@rnorth
Copy link
Member

rnorth commented Sep 21, 2018

Released for preview in 1.9.0-rc2, to be published on Bintray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants