Mark Windows npipe support as stable (with a fix) #865
Conversation
kiview
force-pushed
the
windows_fixes
branch
from
afe7e7b
to
728a27f
Compare
core/build.gradle
Outdated
| @@ -36,7 +36,9 @@ shadowJar { | |||
| 'META-INF/services/org.jvnet.hk2.external.generator.*', | |||
| 'META-INF/services/org.glassfish.jersey.internal.spi.*', | |||
| 'META-INF/services/java.security.Provider', | |||
| 'META-INF/services/java.sql.Driver', | |||
There was a problem hiding this comment.
Oh, I think we can remove this now also?
| return os; | ||
| } | ||
|
|
||
| public void setTcpNoDelay(boolean bool) { |
There was a problem hiding this comment.
Why do we need non @Override dummy methods?
| handler.channelRead(null, Unpooled.wrappedBuffer(buffer, 0, bytesReceived)); | ||
| int offset = 0; | ||
| for (int i = 0; i < bytesReceived; i++) { | ||
| if (buffer[i] == '\n' || i == bytesReceived - 1) { |
There was a problem hiding this comment.
Let's just extract those two boolean conditions into two variables, lineBreak and endOfBuffer. Maybe even adding a small comment that line break can happen, if the daemon is answering very fast and it means we got multiple responses.
| int offset = 0; | ||
| for (int i = 0; i < bytesReceived; i++) { | ||
| // some handlers like JsonResponseCallbackHandler do not work with multi-line buffers | ||
| boolean isLineBreak = buffer[i] == '\n'; |
There was a problem hiding this comment.
This one matches any line break, but I assume only line breaks between json objects should be considered (as delimiter for line-delimited JSON). So, what happens when something like below is part of the response? 🤔
{"foo":"bar\nbaz"}
{"anything":"else"}
#756 tested on Windows. Fixed RegistryAuthLocatorTest on Windows and also allowed better fallbacks from running credential provider (to allow lookup alternative AuthConfigs), when: 1) there is no hostName, then there is no point to ask credentials 2) when credential helper response with "credentials not found in native keychain" to try other resources Main reason for failing for me on Windows machine was #710 changes. When i used Netty or OkHttp together with npipe, then it worked fine. Yesterday evening i found out the reason and today morning i found also fix in master for that :-) - #865, breaking docker response by line breaks.
|
Released for preview in 1.9.0-rc2, to be published on Bintray. |
There was a bug in
FramedResponseStreamHandler: if buffer has two lines, only first one was processed. Fixed by manually chunking the buffer