-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to change password in MSSQLServerContainer #885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@StefanHufschmidt ?
Since MS SQL Server requires a "strong" password we maybe should add a validation? |
@StefanHufschmidt Good point, it won't boot else? |
Yes exactly. I don't know if it would be enough if the user of testcontainers would only see the startup error message. Nevertheless I would like to have some tests for setting a custom password then. Maybe including one for a weak password as well. In my opinion there should be a validation which throws an exception if the password is not "strong" so I can directly see where I have a mistake in my setup and not have to check the startup error. |
Sounds good from a UX standpoint. Let's do it if the validation part is minimal (and we generate value by adding the setter for password). |
Sure, I'll follow the rules I found here, right? |
@ecostanzi Any news on this? |
Hi, not yet, I hope to PR asap in the next few days |
Hey @ecostanzi, PR looks pretty nice now, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code style was a bit off (missing whitespaces).
We have an .editorconfig
in the project root, but I'm not sure, if it would format those accordingly ATM.
modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java
Outdated
Show resolved
Hide resolved
modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java
Outdated
Show resolved
Hide resolved
modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java
Outdated
Show resolved
Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java
Outdated
Show resolved
Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java
Outdated
Show resolved
Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java
Outdated
Show resolved
Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java
Outdated
Show resolved
Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java
Outdated
Show resolved
Hide resolved
...ssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerPasswordTest.java
Outdated
Show resolved
Hide resolved
modules/mssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerTest.java
Outdated
Show resolved
Hide resolved
Hi sorry I forgot to format the code. It should be ok now. |
modules/mssqlserver/src/test/resources/container-license-acceptance.txt
Outdated
Show resolved
Hide resolved
modules/mssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerTest.java
Outdated
Show resolved
Hide resolved
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
Hi, i comment in order to keep this PR alive. This could be merged I just need to know if the tests are necessary or not. |
modules/mssqlserver/src/test/java/org/testcontainers/containers/MSSQLServerContainerTest.java
Outdated
Show resolved
Hide resolved
@ecostanzi Terribly sorry for the late answer, sometimes activity in issues gets missed 😞 |
Circle-CI is failing because of missing Oracle image, tests not ignored yet on this branch. @ecostanzi Thanks for your contribution, merged! |
As for PostgresSQLContainer, this allow to change the default password in the SQL Server Container.