Add Travis job for examples #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Oct 4, 2018
.travis.yml
Outdated
| @@ -38,6 +38,9 @@ jobs: | |||
| openjdk:8-jdk-alpine \ | |||
| ./gradlew --no-daemon testcontainers:test --tests '*GenericContainerRuleTest' | |||
|
|
|||
| - env: [ NAME="examples"] | |||
There was a problem hiding this comment.
WDYT about adding it to CircleCI instead?
Otherwise we will be running it during the release (while depending on SNAPSHOT from Jitpack)
There was a problem hiding this comment.
Sure, was even thinking about adding it to both.
But your reasoning makes sense, so I switch.
bsideup
approved these changes
Oct 4, 2018
dbyron0
referenced
this pull request
in locationlabs/testcontainers-java
Oct 10, 2018
Also fixes failing SeleniumContainerTest in examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized (while reviewing #893), that our examples are not part of the CI. I'm not sure if this was a conscious decision, but I suppose not.
For now, I just added an additional job to Travis using maven, but I think it makes sense to migrate them to Gradle in a next step.