Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate gradle build scans for CI builds #916

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Activate gradle build scans for CI builds #916

merged 1 commit into from
Nov 5, 2018

Conversation

britter
Copy link
Contributor

@britter britter commented Oct 14, 2018

As discussed via twitter this PR will activate build scans for CI builds. For an example see this scan of a local build on my machine.

I had to add some configuration to build.gralde for this:

  • The build scan plugin is applied first. Otherwise it will not collect all data for Gradle < 4.3.
  • The terms of service are accepted via the corresponding configuration in build.gradle. Every build that is called with the --scan option will be published. @melix suggested to add a more sophisticated configuration, that will also publish all local builds if user accept it. For now I've only added the simple configuration.

Furthermore I've added the --scan option to all travis stages.

@kiview
Copy link
Member

kiview commented Oct 14, 2018

While I generally like feature (although I haven't looked into the scan result in much detail), I wonder if there is a way, to make the scan result public by default?

Right now, one has to activate the scan result by visiting the URL logged by TravisCI and providing an email. I think it would be much nicer, if they would be activated by default, but maybe I'm misreading the actual workflow (being mainly an on-demand one).

We could add the --scan flag to CirceCI as well.

@kiview
Copy link
Member

kiview commented Oct 14, 2018

Never mind my comment, seems this was for creating an user account.

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine to me, thank you!
As the scan only occurs on CI builds I can't see there being any privacy risk to contributors.

@rnorth rnorth merged commit 0bf68e9 into testcontainers:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants