Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose support for --build and --rmi options #924

Closed
wants to merge 1 commit into from

Conversation

lightoze
Copy link

No description provided.

@rnorth
Copy link
Member

rnorth commented Oct 27, 2018

Ah, thank you @lightoze, this seems like a sensible addition!

Could you possibly create a test in case we accidentally break this in the future?
If the rmi feature is too hard to test then maybe skip that, but I imagine it should be possible to create a test for the build flag.

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment, please add test coverage.

@sonerd
Copy link
Contributor

sonerd commented Dec 7, 2018

Hi @lightoze,

this feature was something I was looking for. Nice. When do you think you can write the tests so it can be merged?

@stale
Copy link

stale bot commented Mar 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Mar 7, 2019
@rnorth
Copy link
Member

rnorth commented Mar 18, 2019

I'll apply the help wanted label so that anybody else interested can pick this up, in case @lightoze is too busy.

I think my comment gives the gist of what we'd be after.

@sonerd, would you be interested in picking this up?

@stale stale bot removed the stale label Mar 18, 2019
@sonerd
Copy link
Contributor

sonerd commented Mar 18, 2019

I'll apply the help wanted label so that anybody else interested can pick this up, in case @lightoze is too busy.

I think my comment gives the gist of what we'd be after.

@sonerd, would you be interested in picking this up?

Sure I can give it a try. Should I fork from latest master and cherry-pick the changes made by @lightoze ?

@lightoze
Copy link
Author

@sonerd I would be glad for you doing that. I'm still not getting back to the project where testcontainers is in use.

@sonerd
Copy link
Contributor

sonerd commented Mar 24, 2019

I have created a new PR: #1336

@rnorth
Copy link
Member

rnorth commented Apr 15, 2019

Closing in favour of #1336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants