-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker compose support for --build and --rmi options #924
Conversation
Ah, thank you @lightoze, this seems like a sensible addition! Could you possibly create a test in case we accidentally break this in the future? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per comment, please add test coverage.
Hi @lightoze, this feature was something I was looking for. Nice. When do you think you can write the tests so it can be merged? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
Sure I can give it a try. Should I fork from latest master and cherry-pick the changes made by @lightoze ? |
@sonerd I would be glad for you doing that. I'm still not getting back to the project where testcontainers is in use. |
I have created a new PR: #1336 |
Closing in favour of #1336 |
No description provided.