-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using MariaDB JDBC URL to set database name, user and password #950
Conversation
Also support user name and password using query string parameters. Implementation copied verbatim from `MySQLContainerProvider` to address issue testcontainers#949 .
Required to support the container provider changes for issue testcontainers#949
Hi @guss77, thanks for the PR. testcontainers-java/modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java Line 52 in 1d0140a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests for JDBC driver
Something like this? |
Yes, thanks. |
Interestingly enough, without the MariaDbContainer support for user and password, the only test that fails is This actually makes sense to me - this PR is about obeying the configuration from the URL, so without it the container still starts, but uses the " The only question is why the other tests with a user in the URL didn't fail, and I think I understand why. |
…ed in MariaDB tests
With the last change, all MariaDB tests with a custom user name fail without the PR changes. |
Thanks, LGTM to me now. |
LGTM, thank you @guss77! |
Implement feature compatibility with MySQL container requested in issue #949