Add TcpHost to ElasticsearchContainer #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadoonet
reviewed
Nov 5, 2018
...elasticsearch/src/test/java/org/testcontainers/elasticsearch/ElasticsearchContainerTest.java
Outdated
Show resolved
Hide resolved
dadoonet
reviewed
Nov 5, 2018
...elasticsearch/src/test/java/org/testcontainers/elasticsearch/ElasticsearchContainerTest.java
Outdated
Show resolved
Hide resolved
dadoonet
reviewed
Nov 5, 2018
...elasticsearch/src/test/java/org/testcontainers/elasticsearch/ElasticsearchContainerTest.java
Outdated
Show resolved
Hide resolved
...elasticsearch/src/test/java/org/testcontainers/elasticsearch/ElasticsearchContainerTest.java
Outdated
Show resolved
Hide resolved
rnorth
reviewed
Nov 5, 2018
modules/elasticsearch/src/main/java/org/testcontainers/elasticsearch/TcpHost.java
Outdated
Show resolved
Hide resolved
|
Sorry, but please could you explain the purpose of this change? |
|
The goal is to be able to use the Transport Layer as well. Although it's kind of deprecated it is widely used in the field. That said, at least documentation should be updated to reflect this. |
|
I completed the documentation and added more details to the PR. |
|
Please note circleci failure is probably not my fault :D |
|
Don't know what to conclude from circleci failure: |
|
Merge conflict resolved. |
|
ping :) |
rnorth
reviewed
Nov 19, 2018
modules/elasticsearch/src/main/java/org/testcontainers/elasticsearch/TcpHost.java
Outdated
Show resolved
Hide resolved
...elasticsearch/src/test/java/org/testcontainers/elasticsearch/ElasticsearchContainerTest.java
Outdated
Show resolved
Hide resolved
|
@rnorth , getTcpHost returns an InetSocketAddress now. |
rnorth
reviewed
Nov 20, 2018
|
Super, thanks @reda-alaoui. I'll merge now. |
rnorth
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications have 2 ways to communicate with ElasticSearch:
ElasticsearchContainer currently only allows the usage of the REST client.
This allows the application to connect to the container via transport client.