Allow to set Shared Memory size (shmSize) for GenericContainer

[fzakaria]

Add the necessary code so that shmSize can be set on a GenericContainer.

This is especially useful for when starting Oracle docker images because they need at least 1GB of shared memory space.

docker run ... --shm-size=1g oracle/database:11.2.0.2-xe

Fixes #952

[rnorth]

Thanks @fzakaria.

Looks like CircleCI had an unrelated glitch downloading the gradle wrapper so I've restarted the build.

[fzakaria]

Thanks @rnorth -- looks to have been resolved.

[fzakaria]

I updated the PR to have shmSize be simply bytes instead of 'megabytes' to avoid mebibyte vs megabyte confusion.

[fzakaria]

Looks like travis-ci had a flaky failure pulling an artifact -- could someone restart.
I believe this PR is ready to merge; thanks.

[kiview]

I've restarted Travis and added some comments up for discussion.

[fzakaria]

Thanks for feedback @kiview -- I've addressed them with latest update.

• moved to busybox + try-with-resources in the test
• moved HostConfig to a buildHostConfig
• removed extra assert

[kiview]

Great changes, thanks!
I found one more small thing in the Javadoc.

[fzakaria]

Updated @kiview .

[fzakaria]

@kiview What's next step to get this merged & published?

[kiview]

Hey @fzakaria, sorry for letting this hanging, I think it's good to go.
I'll ping the others about final feedback and then we can merge.

[fzakaria]

@bsideup made changes requested.

[fzakaria]

Update on this ? Quite a lot of effort to get a helpful change in.
I might abandon the process soon.

[kiview]

Hi @fzakaria,
as said before, thanks for the PR.

I can understand your frustration, but please keep in mind, that we are working on Testcontainers in our spare time. As such, there might be periods of time, were each of us can't invest the time we'd like to ideally invest into the project.

I have requested a tiny change (remove blank lines to reduce the diff) and then I'll merge directly.

[fzakaria]

@kiview thanks.
Sorry for the attitude -- other stuff that day was likely getting to me.

[kiview]

Travis failure unrelated, restarted.

[kiview]

@fzakaria merged, thanks a lot for the great PR as well as your patience 🙂