sqlserver jdbc url should be supported by container provider

[neetkee]

Solution to #988

[kiview]

Hey, thanks for the PR.

So using a "wrong" JDBC url like jdbc:tc:mssqlserver:2017-CU12://somehost:someport;databaseName=test also never worked?

[neetkee]

It's possible to use JDBC url with mssqlserver, mentioned it here

[kiview]

@StefanHufschmidt Can you give it a look please?

[StefanHufschmidt]

LGTM

[StefanHufschmidt]

Btw do we automatically accept the license agreement on this ms sql server image in our tests?
Might that cause some problems for us?

[kiview]

@StefanHufschmidt You mean legal problems?
We accept it in the jdbc-test module.

[kiview]

@neetkee This will be a breaking API change, correct?
Would it make sense, to support both names?

[neetkee]

@kiview Yes, it will be the breaking change for those, who use this image as temporary database container. But I'm not sure if we need to keep mssqlserver jdbc url working, documentation says that to work with it, it's only needed to Insert tc: after jdbc:

[kiview]

The failing tests in CI aren't a direct error in this PR, but are coming from #992.
They only appear in this PR, since we didn't have MS SQL tests before it seems?

[neetkee]

Is there anything I need to do?

[bsideup]

Pinging @kiview

[kiview]

@neetkee Whoops sorry, everything looks good.
Since this is kind of API breaking, we should mention it in the release notes, but it's the right thing to do.

Thanks for your contribution!