Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OneShotStartupCheckStrategy like testcontainers-java #731

Closed
omerlh opened this issue Mar 17, 2024 · 2 comments
Closed

Support OneShotStartupCheckStrategy like testcontainers-java #731

omerlh opened this issue Mar 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@omerlh
Copy link
Contributor

omerlh commented Mar 17, 2024

Hey!
Very happy users of testcontainers here :) We have a use case where we need something similar to OneShotStartupCheckStrategy that test containers java supports.
It is pretty easy to implement it ourselves using StartupCheckStrategy but I am also happy contribute the code back to the library so others could use it as well.

While trying to write and test for it I am getting weird error:

Container runtime strategy "UnixSocketStrategy" does not work TypeError: dockerode.info is not a function 

I added the exception to find out why my tests are not passing and this is the additional string on the error. Happens both locally and when running on codespaces. What am I a doing wrong? I would like help so I could open a pull request - i pushed my (not working changes) to a branch - #730.

@cristianrgreco cristianrgreco added the enhancement New feature or request label Mar 17, 2024
@cristianrgreco
Copy link
Collaborator

Hey @omerlh, thanks for contributing! I'll reply with feedback on the PR on the PR itself

@cristianrgreco
Copy link
Collaborator

Added in #730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants