-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OneShotWaitStrategy
#730
Add OneShotWaitStrategy
#730
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@omerlh I think the issue is that the container runtime strategy is injected into the wait strategy before it is initialised. There is a complexity in that the runtime initialisation is lazy, and a user defines their wait strategy before any container is started. I reckon you want to get the container runtime strategy in the wait strategy itself instead of passing it in. |
I wasn't sure - I tried following the docs on creating a wait strategy that needs the container client, but seemed weird to me I need to pass it on the ctor. I guess you are saying I should not use |
I let myself change StartupCheckStrategy to get the container runtime only when checking but it is still failing with the same error... |
Yes that's right |
So look at my latest changes - I think I did that, but it still failing... |
packages/testcontainers/src/wait-strategies/one-shot-startup-startegy.test.ts
Outdated
Show resolved
Hide resolved
Could you please add an example in the wait strategies doc? |
Tests are failing:
|
Sure, I think I fixed both! |
Thanks for merging! |
No description provided.