Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump docker from 7.0.0 to 7.1.0 #583

Conversation

tarilabs
Copy link

Hi 👋
my attempt at #577 since that is affecting our project as well, cannot replicate testing on my machine (regardless of this upgrade) so trusting in GHA while raising this PR, hope this helps?

Copy link
Collaborator

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, what? our CI never broke - we need someone who is facing the issue to test. Otherwise this involves figuring out where we use http+docker - is that used over unix sockets? is that only on windows? @NikiforovG would know - he faced the issue, so would @ErwinJapie , or presumably any of the other folks who liked the comments on #577.

lastly, this doesn't make sense to bump docker without setting requests version to one of the problematic ones, which i believe by now are yanked - https://pypi.org/project/requests/#history - perhaps 2.32.2 is still broken, I have not checked myself

@alexanderankin alexanderankin marked this pull request as draft May 27, 2024 08:48
@tarilabs
Copy link
Author

wait, what? our CI never broke

not what I said, and sorry if I was not able to express myself fully.
On my machine, checking out main and poetry run pytest core/ fails on main, but that might be due to my system configuration.

Hence I raised the PR to trust on the GHA CI.

@tarilabs
Copy link
Author

lastly, this doesn't make sense to bump docker without setting requests version to one of the problematic ones, which i believe by now are yanked - https://pypi.org/project/requests/#history - perhaps 2.32.2 is still broken, I have not checked myself

sorry I missed this, I made the assumption docker enforced this ^version, and after your comment I realize it's not.

@tarilabs
Copy link
Author

Shall I enforce requests to ^2.32.2 in pyproject.toml ?

@kiview
Copy link
Member

kiview commented May 27, 2024

@tarilabs From my understanding, since the new version of docker-py is already released, it should be fixed for users of our testcontainers-python as well when installing dependencies.

@tarilabs
Copy link
Author

@tarilabs From my understanding, since the new version of docker-py is already released, it should be fixed for users of our testcontainers-python as well when installing dependencies.

ack, I thought i'd use this to bump the lock file for this project benefit too,

name = "docker"
version = "7.0.0"

and

name = "requests"
version = "2.31.0"

as I thought is the same kind of issue, but I might have missed something.

thanks anyway :)

@tarilabs tarilabs closed this May 27, 2024
@kiview
Copy link
Member

kiview commented May 27, 2024

No worries, I originally thought the same, until I was further educated on the idiosyncrasies of the Python ecosystem (I'm mostly a Java dev). Thanks for helping out 🙌

@tarilabs
Copy link
Author

No worries, I originally thought the same, until I was further educated on the idiosyncrasies of the Python ecosystem (I'm mostly a Java dev). Thanks for helping out 🙌

can you share some educational sources you are referring to @kiview here, please?
I'm mostly from Java background too 😅 so I could make the use of it too :)

@alexanderankin
Copy link
Collaborator

can you share about how it is broken on your machine, ideally your machine exhibits same behavior as this repo's ci, which as above, does not break due to this http+docker issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants