-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Typing in docker_client #702
base: main
Are you sure you want to change the base?
fix(core): Typing in docker_client #702
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage ? 85.37%
=======================================
Files ? 12
Lines ? 670
Branches ? 105
=======================================
Hits ? 572
Misses ? 75
Partials ? 23 ☔ View full report in Codecov by Sentry. |
Please note: core/testcontainers/core/config.py:46: error: X | Y syntax for unions requires Python 3.10 [syntax]
connection_mode: str | None = environ.get("TESTCONTAINERS_CONNECTION_MODE") Found when rebasing and updated to support 3.9 (I'm not aware of deprecating 3.9 in tc-python, feel free to update) |
@alexanderankin @kiview can you please rerun this? (I assume this was an issue with the docker registry) |
Supports: #305
Related : #691 #692 #700
Based on #504, kudos @alexanderankin
Old
New