-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "pro" variant for LocalStack image #255
feat: add "pro" variant for LocalStack image #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, a few comments to discuss only
Thank you! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
0df988a
to
95dabe2
Compare
@DDtKey Some of the CI is failing, but it doesn't seem like it's the new code?
Reasonably certain I could fix the CI for both of those, but I don't think it should be a part of this PR. Want me to take a crack at it as a separate PR? 🤔 |
Yes, I guess MSRV was bumped as part of path/minor version of the dependency. We can either stick it to particular version, or consider MSRV update, but as a breaking change. Using specific version of dependency may be a pain for our users, if they already updated it |
What's that mean for this PR? Does it need to wait until CI can be fixed? |
Not really, it's merged But we need fixes for the next release |
PR adds a "pro" variant of the existing LocalStack image.