Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "pro" variant for LocalStack image #255

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

the-wondersmith
Copy link
Contributor

@the-wondersmith the-wondersmith commented Dec 18, 2024

PR adds a "pro" variant of the existing LocalStack image.

Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a few comments to discuss only

Thank you! 🙏

src/localstack/mod.rs Outdated Show resolved Hide resolved
src/localstack/mod.rs Show resolved Hide resolved
src/localstack/mod.rs Outdated Show resolved Hide resolved
@DDtKey DDtKey changed the title feat: Add "pro" variant for LocalStack image + bump pinned version feat: Add "pro" variant for LocalStack image Dec 19, 2024
@DDtKey DDtKey changed the title feat: Add "pro" variant for LocalStack image feat: add "pro" variant for LocalStack image Dec 19, 2024
Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@the-wondersmith
Copy link
Contributor Author

@DDtKey Some of the CI is failing, but it doesn't seem like it's the new code?

  • MSRV failed on default (somehow) and cncf_distribution
error: package `home v0.5.11` cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.75.0
  • stable and nightly both failed on oracle
Error: DpiError(DbError { code: 0, offset: 0, message: "DPI-1047: Cannot locate a 64-bit Oracle Client library: \"libaio.so.1: cannot open shared object file: No such file or directory\". See https://oracle.github.io/odpi/doc/installation.html#linux for help", fn_name: "dpiContext_createWithParams", action: "load library", is_recoverable: false, is_warning: false })

Reasonably certain I could fix the CI for both of those, but I don't think it should be a part of this PR. Want me to take a crack at it as a separate PR? 🤔

@DDtKey
Copy link
Contributor

DDtKey commented Dec 20, 2024

Yes, I guess MSRV was bumped as part of path/minor version of the dependency.

We can either stick it to particular version, or consider MSRV update, but as a breaking change.

Using specific version of dependency may be a pain for our users, if they already updated it
I think we can consider update of MSRV in separate PR

@the-wondersmith
Copy link
Contributor Author

Yes, I guess MSRV was bumped as part of path/minor version of the dependency.

We can either stick it to particular version, or consider MSRV update, but as a breaking change.

Using specific version of dependency may be a pain for our users, if they already updated it I think we can consider update of MSRV in separate PR

What's that mean for this PR? Does it need to wait until CI can be fixed?

@DDtKey DDtKey merged commit 283daee into testcontainers:main Dec 21, 2024
3 of 6 checks passed
@DDtKey
Copy link
Contributor

DDtKey commented Dec 21, 2024

Not really, it's merged

But we need fixes for the next release

@the-wondersmith the-wondersmith deleted the feat/localstack-pro branch December 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants