-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parity with testcontainers-java #102
Conversation
@LMnet wow! |
@dimafeng ready for the review :) |
|
||
import org.testcontainers.containers.{ClickHouseContainer => JavaClickHouseContainer} | ||
|
||
class ClickHouseContainer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to have all classes declared as case classes for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@LMnet seems the build is failing due to
|
Fixed errors |
Fix for #95, #80
Most of the changes here are pretty mechanical. But some containers were pretty complex.
I didn't add tests. This is not good in general, but most of the containers are so simple and straightforward so I think it could be done in the future when some issues will be found.
A detailed review of changes you can find in the changelog section of the readme.