Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity with testcontainers-java #102

Merged
merged 2 commits into from
Jan 19, 2020
Merged

Conversation

LMnet
Copy link
Contributor

@LMnet LMnet commented Jan 18, 2020

Fix for #95, #80

Most of the changes here are pretty mechanical. But some containers were pretty complex.

I didn't add tests. This is not good in general, but most of the containers are so simple and straightforward so I think it could be done in the future when some issues will be found.

A detailed review of changes you can find in the changelog section of the readme.

@dimafeng
Copy link
Collaborator

@LMnet wow!

@LMnet
Copy link
Contributor Author

LMnet commented Jan 19, 2020

@dimafeng ready for the review :)


import org.testcontainers.containers.{ClickHouseContainer => JavaClickHouseContainer}

class ClickHouseContainer(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to have all classes declared as case classes for consistency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dimafeng
Copy link
Collaborator

@LMnet seems the build is failing due to

[pool-1-thread-1] INFO 🐳 [docker-compose] - Docker Compose has finished running

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/db2/target/scala-2.11/classes ...

[info] Done compiling.

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/postgres/target/scala-2.11/classes ...

[info] Done compiling.

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/mysql/target/scala-2.11/classes ...

[info] Done compiling.

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/oracle/target/scala-2.11/classes ...

[info] Done compiling.

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/mssqlserver/target/scala-2.11/classes ...

[error] /home/travis/build/testcontainers/testcontainers-scala/modules/mssqlserver/src/main/scala/com/dimafeng/testcontainers/MSSQLServerContainer.scala:8:1: identifier expected but ')' found.

[error] ) extends SingleContainer[JavaMSSQLServerContainer[_]] with JdbcDatabaseContainer {

[error] ^

[error] /home/travis/build/testcontainers/testcontainers-scala/modules/mssqlserver/src/main/scala/com/dimafeng/testcontainers/MSSQLServerContainer.scala:38:2: ':' expected but eof found.

[error] }

[error]  ^

[error] two errors found

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/clickhouse/target/scala-2.11/classes ...

[error] /home/travis/build/testcontainers/testcontainers-scala/modules/clickhouse/src/main/scala/com/dimafeng/testcontainers/ClickHouseContainer.scala:8:1: identifier expected but ')' found.

[error] ) extends SingleContainer[JavaClickHouseContainer] with JdbcDatabaseContainer {

[error] ^

[error] /home/travis/build/testcontainers/testcontainers-scala/modules/clickhouse/src/main/scala/com/dimafeng/testcontainers/ClickHouseContainer.scala:38:2: ':' expected but eof found.

[error] }

[error]  ^

[error] two errors found

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/mariadb/target/scala-2.11/classes ...

[info] Done compiling.

[info] Compiling 1 Scala source to /home/travis/build/testcontainers/testcontainers-scala/modules/cockroachdb/target/scala-2.11/classes ...

[error] /home/travis/build/testcontainers/testcontainers-scala/modules/cockroachdb/src/main/scala/com/dimafeng/testcontainers/CockroachContainer.scala:7:1: identifier expected but ')' found.

[error] ) extends SingleContainer[JavaCockroachContainer] with JdbcDatabaseContainer {

[error] ^

[error] /home/travis/build/testcontainers/testcontainers-scala/modules/cockroachdb/src/main/scala/com/dimafeng/testcontainers/CockroachContainer.scala:30:2: ':' expected but eof found.

[error] }

[error]  ^

[error] two errors found

@LMnet
Copy link
Contributor Author

LMnet commented Jan 19, 2020

Fixed errors

@LMnet LMnet changed the title WIP: Parity with testcontainers-java Parity with testcontainers-java Jan 19, 2020
@dimafeng dimafeng merged commit 3e06cca into testcontainers:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants