Migrate to Docker Compose v2 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dimafeng I have rebased on the latest master, would you mind taking a look? thanks. |
|
@dimafeng, thanks, and would be nice if you can trigger a release 😄 |
|
released 🎉 |
|
nice! thank you @dimafeng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #259 to get merged first.
Close #200
This PR aims to migrate to the backend of
com.dimafeng.testcontainers.DockerComposeContainerfrom Docker Compose V1 (a.k.adocker-compose) to the Docker Compose V2 (a.k.adocker compose)See more details at testcontainers/testcontainers-java#5608
https://docs.docker.com/compose/migrate/
Compose V1 actually reached EOL, and Compose V2 has been adopted for a long time, so I suppose the change won't break user experience.
Before this PR,
docker-composeis necessary for launching compose files.After this PR, all tests passed without
docker-composebut onlydockercommands