Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Example copy and paste ready #433

Closed
shaman-apprentice opened this issue Jan 29, 2024 · 0 comments · Fixed by #434
Closed

Make Example copy and paste ready #433

shaman-apprentice opened this issue Jan 29, 2024 · 0 comments · Fixed by #434

Comments

@shaman-apprentice
Copy link
Contributor

shaman-apprentice commented Jan 29, 2024 •
edited
Loading

As a developer having an example, I can just copy and paste which compiles and passes, helps me to get quickly to speed.

Currently, creating a new app, installing needed dependencies and just copy passing the example from README.md results in a broken test.

I will submit a PR with an easy fix. Feel free to adjust as you like - and thanks a lot for your work in general.
shaman-apprentice added a commit to shaman-apprentice/angular-testing-library that referenced this issue Jan 29, 2024
@shaman-apprentice
docs: Fix example (testing-library#433)
2d6c76c
@shaman-apprentice shaman-apprentice mentioned this issue Jan 29, 2024
Merged
timdeschryver pushed a commit that referenced this issue Jan 30, 2024
@shaman-apprentice
docs: Fix example (#433) (#434)
87d02f2 
Closes #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Fix example (#433) shaman-apprentice/angular-testing-library
1 participant
@shaman-apprentice