fix: remove extra command log message for get* queries (#106)

Related to #103
testing-library · Jan 29, 2020 · 2f62901 · 2f62901
1 parent da1dc4d
commit 2f62901
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/cypress/integration/get.spec.js b/cypress/integration/get.spec.js
@@ -19,6 +19,23 @@ describe('get* queries should error', () => {
 
                 cy[`${obsoleteQueryName}`]('Irrelevant')
             })
+
+            it(`${obsoleteQueryName} should not log more than once`, () => {
+
+                let logCount = 0
+                cy.on('log:added', (attrs, log) => {
+                    if (log.get('name') === obsoleteQueryName) {
+                        logCount = logCount + 1
+                    }
+                })
+
+                cy.on('fail', _ => {
+                    expect(logCount).to.equal(1)
+                    cy.removeAllListeners('log:added')
+                })
+
+                cy[`${obsoleteQueryName}`]('Irrelevant')
+            })
         })
     })
 })

diff --git a/src/index.js b/src/index.js
@@ -21,10 +21,6 @@ const getCommands = getQueryNames.map(queryName => {
   return {
     name: queryName,
     command: () => {
-      Cypress.log({
-        name: queryName,
-      })
-
       throw new Error(
         `You used '${queryName}' which has been removed from Cypress Testing Library because it does not make sense in this context. Please use '${queryName.replace(
           getRegex,