CypressError: cy.findByText() failed because it requires the subject be a global 'document' object.

[leosuncin]

• cypress-testing-library version: 5.2.0
• node version: 13.7.0
• npm (or yarn) version: 6.13.6

Relevant code or config

it('should validate the credentials', () => {
    cy.findByText(/Log me in/i)
      .click()
      .findByText(/Username should not be empty/i)
      .findByText(/Password should not be empty/i);
});

What you did: Bump @testing-library/cypress from 5.0.2 to 5.2.0

What happened:

  1) Register page should validate the data:                                                                                                                                                                                      [149/2152]
     CypressError: cy.findByText() failed because it requires the subject be a global 'document' object.                                                                                                                                    
The subject received was:

<span.MuiButton-label>

The previous command that ran was:

cy.click()

All 3 subject validations failed on this subject.

at Object.cypressErr (http://localhost:3000/__cypress/runner/cypress_runner.js:86207:11)

at Object.throwErr (http://localhost:3000/__cypress/runner/cypress_runner.js:86162:18)

at Object.throwErrByPath (http://localhost:3000/__cypress/runner/cypress_runner.js:86194:17)

at ensureDocument (http://localhost:3000/__cypress/runner/cypress_runner.js:74338:21)

at validateType (http://localhost:3000/__cypress/runner/cypress_runner.js:74184:16)

at Object.ensureSubjectByType (http://localhost:3000/__cypress/runner/cypress_runner.js:74210:9)

at pushSubjectAndValidate (http://localhost:3000/__cypress/runner/cypress_runner.js:81127:15)

at Context. (http://localhost:3000/__cypress/runner/cypress_runner.js:81413:18)

at http://localhost:3000/__cypress/runner/cypress_runner.js:80892:33

at tryCatcher (http://localhost:3000/__cypress/runner/cypress_runner.js:120203:23)

at Promise._settlePromiseFromHandler (http://localhost:3000/__cypress/runner/cypress_runner.js:118139:31)

at Promise._settlePromise (http://localhost:3000/__cypress/runner/cypress_runner.js:118196:18)

at Promise._settlePromiseCtx (http://localhost:3000/__cypress/runner/cypress_runner.js:118233:10)

at Async../node_modules/bluebird/js/release/async.js.Async._drainQueue (http://localhost:3000/__cypress/runner/cypress_runner.js:114933:12)

at Async../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://localhost:3000/__cypress/runner/cypress_runner.js:114938:10)

at Async.drainQueues (http://localhost:3000/__cypress/runner/cypress_runner.js:114812:14)

https://github.com/leosuncin/mui-next-ts/pull/26/checks?check_run_id=421662750

Reproduction repository:

https://github.com/leosuncin/mui-next-ts/tree/dependabot/npm_and_yarn/testing-library/cypress-5.2.0

Problem description:

Suggested solution:

it('should validate the credentials', () => {
    cy.findByText(/Log me in/i)
      .click();
    cy.findByText(/Username should not be empty/i)
      .findByText(/Password should not be empty/i);
});

[NicholasBoll]

Thanks for the detailed issue. I'll look into this.

The logic should be trying the previous subject first (in your case, the element containing "Log me in"). If the cy.findByText(/Username should not be empty/i) fails with that subject, it should retry with the original logic.

Something about that fallback doesn't seem to be working in your case and I'll look into why.

My best guess is this error is coming from Cypress and not the logic of this command. The command is registered to receive no subject, an element, the document or window. It seems to be receiving something other than those types and Cypress is throwing that error.

[NicholasBoll]

I don't have quick access to an environment to test my theory. If you can manually edit the node_modules/@testing-library/cypress/dust/index.js file and remove the strings 'element', 'document', 'window' from the array at line https://github.com/testing-library/cypress-testing-library/blob/master/src/index.js#L47, save and restart Cypress, does that fix the issue?

[leosuncin]

I don't have quick access to an environment to test my theory. If you can manually edit the node_modules/@testing-library/cypress/dust/index.js file and remove the strings 'element', 'document', 'window' from the array at line https://github.com/testing-library/cypress-testing-library/blob/master/src/index.js#L47, save and restart Cypress, does that fix the issue?

It works

[NicholasBoll]

If you have time, feel free to open a pull request with that change. A test that verifies the existing failure and changed code passing, that be great.

If not, we can get to it on Monday.

[leosuncin]

If you have time, feel free to open a pull request with that change. A test that verifies the existing failure and changed code passing, that be great.

If not, we can get to it on Monday.

WIP

[kentcdodds]

🎉 This issue has been resolved in version 5.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀