Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dom-testing-library #14

Merged
merged 2 commits into from
Aug 23, 2018
Merged

upgrade dom-testing-library #14

merged 2 commits into from
Aug 23, 2018

Conversation

gnapse
Copy link
Member

@gnapse gnapse commented Aug 23, 2018

What:

  • Upgrade dom-testing-library
  • Upgrade serve, mainly because it was printing a warning about a newer version.
  • In the process I added a jest config setting without which I got weird errors. See this for details. Not sure why it has not been an issue for others so far.

Why:

The main motivation was upgrading dom-testing-library just to keep it up to date with the latest and greatest.

How:

By updating the dependency version numbers in package.json.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

Also upgraded `serve` because it was giving a warning when running it.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thank you :)

@kentcdodds kentcdodds merged commit 557591b into testing-library:master Aug 23, 2018
@gnapse gnapse deleted the f/upgrade-some-dependencies branch August 23, 2018 18:14
@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants