Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move typings to src and update reference in package.json #18

Closed
wants to merge 1 commit into from
Closed

Move typings to src and update reference in package.json #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.0-semantically-released",
"description": "Simple and complete custom Cypress commands and utilities that encourage good testing practices.",
"main": "dist/index.js",
"typings": "typings",
"typings": "dist/typings",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of moving the files, could we just include typings in the files property here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I tried first but for some reason it wasn't working. I assume it's because of the way kcd-scripts build works. It seems to take files from src only.

"engines": {
"node": "> 6"
},
Expand Down
0 typings/index.d.ts → src/typings/index.d.ts
View file
Open in desktop
File renamed without changes.
0 typings/tsconfig.json → src/typings/tsconfig.json
View file
Open in desktop
File renamed without changes.
0 typings/tslint.json → src/typings/tslint.json
View file
Open in desktop
File renamed without changes.