Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/improve command log #35

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

jkdowdle
Copy link
Contributor

What:
Add a proper message to the Cypress Command Log when using a regex value.

Why:
This will improve the debugging and developing experience while using cypress-testing-library and it will close #27.

How:
Adding a check in Cypress.log for the message property. If the argument passed is a regular expression we return that value after casting it to a string.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 💯 Thanks!

@kentcdodds kentcdodds merged commit 408a929 into testing-library:master Feb 12, 2019
@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@euZebe
Copy link
Contributor

euZebe commented Feb 13, 2019

Thanks @jkdowdle !

@jkdowdle
Copy link
Contributor Author

@euZebe You're very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regex selector does not appear in cypress left panel
3 participants