fix(TS): Cypress commands return jQuery objects (#58)

[NoriSte]

Some functions have not the right typings. I started from the getByLabelText function to discover that the bug affects all the following functions

getByAltText
getByDisplayValue
getByLabelText
getByRole
getBySelectText
getByTestId
getByText
getByTitle

@aaronmcadam (partially) fixed it in #56 but the functions above were left untouched. @aaronmcadam I'm not sure why you have not fixed the above functions too.

Why:
Because you can not consume the getByLabelText etc. functions with the right/expected flow

How:

To be sure that I'm making the correct thing I proceeded this way:

• accordingly to the actual typing, the above functions should return standard HTML elements, I've asserted that adding

.then($el => {
   expect(Cypress.dom.isJquery($el)).to.eq(false);
})

to the existing tests.

• the tests fail

• then, I reverted the assertion and they succeed. I'm now sure that the returned subject is a jQuery instance.

So, I have updated the typings file and I've added one more TS test.

Checklist:

• Documentation
• Tests
• Ready to be merged

Fixes #58

Thank you for the amazing library ❤️

[aaronmcadam]

@NoriSte if I use @ts-ignore on the example used in #58, the test passes. If I inspect the returned value, it is a jQuery element.

[aaronmcadam]

The missing typings were an oversight, I thought they'd already been typed properly.

[aaronmcadam]

@kentcdodds I've reviewed the PR and accepted it. Are we good to merge?

[kentcdodds]

Looks great! Thanks!

[kentcdodds]

@all-contributes please add @NoriSte for code

[kentcdodds]

@all-contributors please add @NoriSte for code and tests

[allcontributors]

@kentcdodds

I've put up a pull request to add @NoriSte! 🎉

[NoriSte]

Thank you for all guys ❤️

[NoriSte]

The missing typings were an oversight, I thought they'd already been typed properly.

You made me thought I was missing a key point 😁

[kentcdodds]

🎉 This PR is included in version 4.0.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀