Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default branch CI build #663

Closed
kentcdodds opened this issue Jun 23, 2020 · 4 comments · Fixed by #664
Closed

Fix default branch CI build #663

kentcdodds opened this issue Jun 23, 2020 · 4 comments · Fixed by #664
Labels

Comments

@kentcdodds
Copy link
Member

I think when I merged this PR I had assumed the build passed because of codecov's comment which shouldn't appear until we have a successful build. I'm still not sure what happened there to be honest.

But in any case, since that PR was merged (which really just updated aria-query) our tests have been failing. Mostly the suggestion tests, but some others as well.

Could someone dive in and help. You don't have to do it all. Even fixing a few would be helpful.

I think we could especially use help from @benmonro who wrote most of the suggestion tests. In particular, aria-query now gives us a role of generic for generic elements. I'm not 100% certain I want to recommend screen.getByRole('generic', {name: /bob/i}) over screen.getByText(/bob/i)... So I'm thinking we should probably skip that suggestion if the role is generic.

@kentcdodds kentcdodds changed the title Fix master CI build Fix default branch CI build Jun 23, 2020
@marcosvega91
Copy link
Member

very weird 😕

marcosvega91 added a commit to marcosvega91/dom-testing-library that referenced this issue Jun 23, 2020
@kentcdodds
Copy link
Member Author

🎉 This issue has been resolved in version 7.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benmonro
Copy link
Member

Cool glad this got resolved

@kentcdodds
Copy link
Member Author

@marcosvega91 was fast as lightning! ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants