-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default branch CI build #663
Labels
Comments
2 tasks
very weird 😕 |
4 tasks
marcosvega91
added a commit
to marcosvega91/dom-testing-library
that referenced
this issue
Jun 23, 2020
🎉 This issue has been resolved in version 7.16.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Cool glad this got resolved |
@marcosvega91 was fast as lightning! ⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think when I merged this PR I had assumed the build passed because of codecov's comment which shouldn't appear until we have a successful build. I'm still not sure what happened there to be honest.
But in any case, since that PR was merged (which really just updated
aria-query
) our tests have been failing. Mostly the suggestion tests, but some others as well.Could someone dive in and help. You don't have to do it all. Even fixing a few would be helpful.
I think we could especially use help from @benmonro who wrote most of the suggestion tests. In particular, aria-query now gives us a role of
generic
for generic elements. I'm not 100% certain I want to recommendscreen.getByRole('generic', {name: /bob/i})
overscreen.getByText(/bob/i)
... So I'm thinking we should probably skip that suggestion if the role isgeneric
.The text was updated successfully, but these errors were encountered: