Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kcd-scripts to 13.0.0 #1209

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 29, 2023

What:

Bump kcd-scripts to 13.0.0

Why:

Get newer versions of JSDOM

How:

Bump kcd-scripts to 13.0.0

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f2b661:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #1209 (1f2b661) into alpha (6e2e864) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             alpha     #1209   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          998       998           
  Branches       327       327           
=========================================
  Hits           998       998           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

collectCoverageFrom,
watchPlugins,
...baseConfig
} = require('kcd-scripts/jest')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds Would it make sense to provide kcd-scripts/jest-global and kcd-scripts/jest-project directly so that consumers of kcd-scripts don't have to manually cherry-pick?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me. Happy to merge a PR for that.

@eps1lon eps1lon merged commit 25dc8a9 into testing-library:alpha Jan 29, 2023
@eps1lon eps1lon deleted the test/kcd-scripts-bump-13 branch January 29, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants