chore: switch to github actions #809
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| name: validate | ||
| on: [push, pull_request] | ||
| jobs: | ||
| main: | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest] | ||
| node: [10.14.2, 12, 14, 15] | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: ⬇️ Checkout repo | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: ⎔ Setup node | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
|
|
||
| - name: 📥 Download deps | ||
| uses: bahmutov/npm-install@v1 | ||
| with: | ||
| useLockFile: false | ||
|
|
||
| - name: ▶️ Run validate script | ||
| run: npm run validate | ||
|
|
||
| - name: ⬆️ Upload coverage report | ||
| uses: codecov/codecov-action@v1 | ||
|
|
||
| release: | ||
| needs: main | ||
| runs-on: ubuntu-latest | ||
| if: | ||
| ${{ contains('master,beta,next,alpha', github.base_ref) && | ||
|
There was a problem hiding this comment. This doesn't appear to work. This job should not run on this PR but it is... I'm not sure how else to skip this job for non-release branches 🤔 There was a problem hiding this comment. Not 100%, but the docs say There was a problem hiding this comment. Oh yeah! I think I need to use |
||
| github.event_name == 'push' }} | ||
| steps: | ||
| - name: ⬇️ Checkout repo | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: ⎔ Setup node | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 14 | ||
|
|
||
| - name: 📥 Download deps | ||
| uses: bahmutov/npm-install@v1 | ||
| with: | ||
| useLockFile: false | ||
|
|
||
| - name: 🏗 Run build script | ||
| run: npm run build | ||
|
|
||
| - name: 🚀 Release | ||
| uses: cycjimmy/semantic-release-action@v2 | ||
| with: | ||
| semantic_version: 16 | ||
| branches: | | ||
| [ | ||
| '+([0-9])?(.{+([0-9]),x}).x', | ||
| 'master', | ||
| 'next', | ||
| 'next-major', | ||
| {name: 'beta', prerelease: true}, | ||
| {name: 'alpha', prerelease: true} | ||
| ] | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need windows here? May be worth trying but might drain free minutes since it doubles the number of runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm reading this incorrectly, there is no limit to how much time the jobs run in total, only in how long an individual job runs: https://docs.github.com/en/free-pro-team@latest/actions/reference/usage-limits-billing-and-administration
There's also a limit on concurrency, but that's probably not a concern either I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only 20 per account. dom-testing-library alone now uses 8 instead of 4. I'm missing some context why we need to introduce the windows run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I figured it was easy and "free," but I guess we can drop windows 👍