Skip to content

Commit

Permalink
Revert "Autogenerate recommended config"
Browse files Browse the repository at this point in the history
  • Loading branch information
benmonro committed Nov 4, 2019
1 parent 0e8b357 commit 0512ce6
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 62 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ Then configure the rules you want to use under the rules section.

```json
{
"rules": {}
"rules": {
"jest-dom/prefer-checked": "error",
"jest-dom/prefer-enabled-disabled": "error",
"jest-dom/prefer-required": "error"
}
}
```

Expand Down
14 changes: 5 additions & 9 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,13 @@ let requireIndex = require('requireindex');
// import all rules in lib/rules
module.exports.rules = requireIndex(__dirname + '/rules');

module.exports.generateRecommendedConfig = rules => {
return Object.entries(rules).reduce(
(memo, [name, rule]) =>
rule.meta.docs.recommended ? { ...memo, [name]: 'error' } : memo,
{}
);
};

module.exports.configs = {
recommended: {
plugins: ['jest-dom'],
rules: module.exports.generateRecommendedConfig(module.exports.rules),
rules: {
'jest-dom/prefer-checked': 'error',
'jest-dom/prefer-enabled-disabled': 'error',
'jest-dom/prefer-required': 'error',
},
},
};
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"generate-readme-table": "node build/generate-readme-table.js"
},
"dependencies": {
"requireindex": "~1.2.0"
"requireindex": "~1.1.0"
},
"devDependencies": {
"eslint": "^6.6.0",
Expand All @@ -30,4 +30,4 @@
"node": ">=0.10.0"
},
"license": "ISC"
}
}
41 changes: 1 addition & 40 deletions tests/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
@@ -1,42 +1,3 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`should have all the rules 1`] = `
Object {
"prefer-checked": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeChecked over checking attributes",
"recommended": true,
"url": "prefer-checked",
},
"fixable": "code",
},
},
"prefer-enabled-disabled": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeDisabled or toBeEnabled over checking attributes",
"recommended": true,
"url": "prefer-enabled-disabled",
},
"fixable": "code",
},
},
"prefer-required": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeRequired over checking properties",
"recommended": true,
"url": "prefer-required",
},
"fixable": "code",
},
},
}
`;
exports[`should have all the rules 1`] = `Object {}`;
11 changes: 1 addition & 10 deletions tests/index.test.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
const { rules, generateRecommendedConfig, configs } = require('../lib/index');
const { rules } = require('../lib/index');

it('should have all the rules', () => {
expect(rules).toMatchSnapshot();
});

it('should have a recommended config with recommended rules', () => {
expect(
generateRecommendedConfig({
good: { meta: { docs: { recommended: true } } },
bad: { meta: { docs: { recommended: false } } },
})
).toEqual({ good: 'error' });
});

0 comments on commit 0512ce6

Please sign in to comment.