fix(no-debug): catch all screen imports (#175)

Closes #174
testing-library · Jun 18, 2020 · 783ced0 · 783ced0
1 parent c3f9b34
commit 783ced0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/lib/rules/no-debug.ts b/lib/rules/no-debug.ts
@@ -8,6 +8,7 @@ import {
   isLiteral,
   isAwaitExpression,
   isMemberExpression,
+  isImportSpecifier,
 } from '../node-utils';
 
 export const RULE_NAME = 'no-debug';
@@ -141,12 +142,11 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
       },
       // checks if import has shape:
       // import { screen } from '@testing-library/dom';
-      'ImportDeclaration ImportSpecifier'(node: TSESTree.ImportSpecifier) {
-        const importDeclarationNode = node.parent as TSESTree.ImportDeclaration;
-
-        if (!hasTestingLibraryImportModule(importDeclarationNode)) return;
-
-        hasImportedScreen = node.imported.name === 'screen';
+      ImportDeclaration(node: TSESTree.ImportDeclaration) {
+        if (!hasTestingLibraryImportModule(node)) return;
+        hasImportedScreen = node.specifiers.some(
+          s => isImportSpecifier(s) && s.imported.name === 'screen'
+        );
       },
       // checks if import has shape:
       // import * as dtl from '@testing-library/dom';

diff --git a/tests/lib/rules/no-debug.test.ts b/tests/lib/rules/no-debug.test.ts
@@ -202,6 +202,18 @@ ruleTester.run(RULE_NAME, rule, {
         },
       ],
     },
+    {
+      // https://github.com/testing-library/eslint-plugin-testing-library/issues/174
+      code: `
+        import { screen, render } from '@testing-library/dom'
+        screen.debug()
+      `,
+      errors: [
+        {
+          messageId: 'noDebug',
+        },
+      ],
+    },
     {
       code: `
         import * as dtl from '@testing-library/dom';