fix: handle multiple imports with no-manual-cleanup (#835)

Co-authored-by: Mario Beltrán <belco90@gmail.com>
testing-library · Nov 9, 2023 · cb84da2 · cb84da2
1 parent 80843f7
commit cb84da2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/lib/rules/no-manual-cleanup.ts b/lib/rules/no-manual-cleanup.ts
@@ -111,15 +111,12 @@ export default createTestingLibraryRule<Options, MessageIds>({
 		return {
 			'Program:exit'() {
 				const testingLibraryImportName = helpers.getTestingLibraryImportName();
-				const testingLibraryImportNode = helpers.getTestingLibraryImportNode();
 				const customModuleImportNode = helpers.getCustomModuleImportNode();
 
-				if (
-					testingLibraryImportName &&
-					testingLibraryImportNode &&
-					testingLibraryImportName.match(CLEANUP_LIBRARY_REGEXP)
-				) {
-					reportCandidateModule(testingLibraryImportNode);
+				if (testingLibraryImportName?.match(CLEANUP_LIBRARY_REGEXP)) {
+					for (const importNode of helpers.getAllTestingLibraryImportNodes()) {
+						reportCandidateModule(importNode);
+					}
 				}
 
 				if (customModuleImportNode) {

diff --git a/tests/lib/rules/no-manual-cleanup.test.ts b/tests/lib/rules/no-manual-cleanup.test.ts
@@ -235,5 +235,22 @@ ruleTester.run(RULE_NAME, rule, {
 					],
 				} as const)
 		),
+		...ALL_TESTING_LIBRARIES_WITH_CLEANUP.map(
+			(lib) =>
+				({
+					code: `
+        import { render } from "${lib}";
+        import { cleanup } from "${lib}";
+        afterEach(cleanup);
+      `,
+					errors: [
+						{
+							line: 3,
+							column: 18,
+							messageId: 'noManualCleanup',
+						},
+					],
+				} as const)
+		),
 	],
 });