prefer-screen-queries: Don't warn if using the baseElement option

[kentcdodds]

This should be acceptable (from the React Testing Library tests):

test('baseElement isolates trees from one another', () => {
  const {getByText: getByTextInA} = render(<div>Jekyll</div>, {
    baseElement: treeA,
  })
  const {getByText: getByTextInB} = render(<div>Hyde</div>, {
    baseElement: treeB,
  })

  expect(() => getByTextInA('Jekyll')).not.toThrow(
    'Unable to find an element with the text: Jekyll.',
  )
  expect(() => getByTextInB('Jekyll')).toThrow(
    'Unable to find an element with the text: Jekyll.',
  )

  expect(() => getByTextInA('Hyde')).toThrow(
    'Unable to find an element with the text: Hyde.',
  )
  expect(() => getByTextInB('Hyde')).not.toThrow(
    'Unable to find an element with the text: Hyde.',
  )
})

[Belco90]

So the use case is basically several renders within same test right? Just trying to find a pattern to apply to the rule.

[timdeschryver]

I think we should take baseElement into account in some of the rules and disable them? (mostly the rules that are working with screen).

[thomaslombart]

If I get it right, we need to make it so prefer-screen-queries doesn't fire if the render function has a container or baseElement option. Is that correct?

[kentcdodds]

That is correct

[gndelia]

I think I can take this one if no one else is taking it

[kentcdodds]

Sounds awesome 🤘

[Belco90]

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀