Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TypeScript types #963

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 19, 2024

Checks

Changes

  • adds types so that usage with eslint.config.js in TypeScript codebases don't result in errors

Context

Now that plugins are imported "naturally" they can be type-checked by TypeScript so it's useful to ship types - for now I've just manually typed the plugin since primarily the only useful thing to have typed is the configs, as things like rules and settings are still not implicitly inferred and trying to automate this would be overkill.

These types match those that we've got in eslint-plugin-jest, eslint-plugin-jest-dom, and other places

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (93a6ab9) to head (7cc514f).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   96.23%   96.33%   +0.09%     
==========================================
  Files          44       46       +2     
  Lines        2419     2481      +62     
  Branches     1000     1028      +28     
==========================================
+ Hits         2328     2390      +62     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Belco90
Copy link
Member

Belco90 commented Nov 20, 2024

Thanks! I'll autogenerate this with tsup when I finish my pending task for setting up a proper bundle to export CJS and ESM formats.

@Belco90 Belco90 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into testing-library:main with commit 041dc1b Nov 20, 2024
41 checks passed
Copy link

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@G-Rath G-Rath deleted the add-types branch November 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants