Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix commitlint local setup #977

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Dec 16, 2024

Checks

Changes

  • Add commitlint packages to the pnpm public hoist pattern

Context

commitlint is currently broken for the commit-msg hook because pnpm can't find the right dependencies. This is caused by the private hoist mechanism from pnpm. For fixing it, I just made all the commitlint packages publicly hoisted. More info in this issue.

When running commitlint with pnpm, the packages must be
added to the public hoist pattern.

More info: conventional-changelog/commitlint#645 (comment)
@Belco90 Belco90 requested a review from a team December 16, 2024 07:55
@Belco90 Belco90 self-assigned this Dec 16, 2024
@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Dec 16, 2024
@Belco90 Belco90 enabled auto-merge December 16, 2024 07:57
@Belco90 Belco90 merged commit 4f36067 into main Dec 18, 2024
31 checks passed
@Belco90 Belco90 deleted the fix-commitlint-local-setup branch December 18, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant