chore: Update all dependencies #190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 235 235
Branches 57 57
=====================================
Hits 235 235
Continue to review full report at Codecov.
|
package.json
Outdated
| }, | ||
| "eslintConfig": { | ||
| "extends": "./node_modules/kcd-scripts/eslint.js", | ||
| "rules": { | ||
| "babel/no-invalid-this": "off", | ||
| "import/prefer-default-export": "off", | ||
| "import/no-unassigned-import": "off" | ||
| "import/no-extraneous-dependencies": "off", |
There was a problem hiding this comment.
Why is this rule complaining all of the sudden?
There was a problem hiding this comment.
It's because of an update in kcd-scripts' ESLint config
There was a problem hiding this comment.
So it wasn't there before? What is it complaining about?
There was a problem hiding this comment.
It's complaining about jsdom not in our dependencies.
There was a problem hiding this comment.
Maybe we should just ignore import/no-extraneous-dependencies in __tests__? 🤔
There was a problem hiding this comment.
jsdom used to be in devDependencies but it got removed in this PR. Rather than disabling the rule, could the dependency be restored?
There was a problem hiding this comment.
@jgoz It's included by jest-environment-jsdom-sixteen
There was a problem hiding this comment.
Right, but there is a require("jsdom") statement inside this repository, which technically makes it an explicit (dev) dependency of this project. Disabling the rule as a whole will prevent us from detecting when any transitive dependency is imported as though it were a direct dependency, not just this one instance.
|
Shouldn’t we also increase the minimum version of node in engines from 8 to 10? |
|
@weyert That's what this discussion was about 🙂 |
|
Sorry Michaël, looks like Github was hiding it on my home. My bad, and the discussion answers my question 👍
Weyert
…
|
|
@jgoz I've updated as you requested 🙂 |
|
This is supposed to be a patch release, right? Or is it a minor release? |
|
🤷♂️ I think I'd call this a patch, but I don't have strong feelings either way. |
|
@all-contributors please add @MichaelDeBoey for infra |
|
I've put up a pull request to add @MichaelDeBoey! 🎉 |
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.