Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add waitForValueToChange shim to migration guide #924

Merged
merged 2 commits into from
Nov 20, 2022

Conversation

develohpanda
Copy link

What: Add tips to migration guide

Why: Suggestion from comment in testing-library/react-testing-library#991 (comment)

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@develohpanda develohpanda changed the title chore(docs): add waitForValueToChange to migration guide chore(docs): add waitForValueToChange shim to migration guide Nov 18, 2022
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
Copy link
Member

@mpeyper mpeyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait to see how you feel about the comment above, but other than that I'm happy to merge this.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (chore/migration-guide@5ba7fe9). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             chore/migration-guide      #924   +/-   ##
=========================================================
  Coverage                         ?   100.00%           
=========================================================
  Files                            ?        15           
  Lines                            ?       246           
  Branches                         ?        34           
=========================================================
  Hits                             ?       246           
  Misses                           ?         0           
  Partials                         ?         0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mpeyper mpeyper merged commit 5fc498f into testing-library:chore/migration-guide Nov 20, 2022
@develohpanda develohpanda deleted the patch-1 branch November 20, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants