-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to github actions #826
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ffe456a:
|
Any ideas why this isn't running on GitHub Actions but testing-library/dom-testing-library#809 was? I was hoping to test this before merging it. |
I think that the |
Uh oh... I think that needs to be fixed upstream in |
TypeScript ESLint issues are failing the build |
Looks like this is because of the |
I keep getting this error after upgrading it, adding a [lint] Error: Error while loading rule '@typescript-eslint/no-unsafe-assignment': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser. |
I'm working on fixing this now |
Alrighty, now eslint-config-kentcdodds will automatically find the |
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 117 140 +23
Branches 16 28 +12
=========================================
+ Hits 117 140 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super duper! Thanks 👏
🎉 This PR is included in version 11.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Generated with
yo kcd-oss
See testing-library/dom-testing-library#809 for rationale and history