fix(event): be robust against incomplete event implementations #1009
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Assign the specific event properties and methods on the events instead of relying on the event constructors.
Why:
Some DOM implementations are incomplete. E.g. Jsdom lacks support for
PointerEvent
and it won't be implemented any time soon.While initializing the events should be out of scope, events lacking the properties we correctly provide for
init
makes for a bad user experience and simply assigning the properties seems sufficient.Closes #926
Return correct modifier state for
Alt
,Control
,Meta
andShift
pergetModifierState
.How:
Replace the
createEvent
imported from@testing-library/dom
with own implementation.Checklist: