-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove circular dependencies #1027
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a097d1:
|
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 85 88 +3
Lines 2076 2061 -15
Branches 702 691 -11
=========================================
- Hits 2076 2061 -15
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
🎉 This PR is included in version 14.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Refactor code to remove circular dependencies.
Why:
Circular dependencies break imports in native CJS.
How:
Move functions that depend on our document/UI abstraction from
utils
intodocument
orevent
.Remove the
System
fromConfig
and directly provide it on theInstance
.Use bound functions on the
Instance
to dispatch events.Checklist: