feat: make several API and implementation improvements #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
===========================================
+ Coverage 99.42% 100.00% +0.57%
===========================================
Files 2 12 +10
Lines 349 374 +25
Branches 89 108 +19
===========================================
+ Hits 347 374 +27
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
11 tasks
kentcdodds
changed the title
This means that by default you do not need to await it
Closed
4 tasks
kentcdodds
added a commit
that referenced
this pull request
Jun 15, 2020
BREAKING CHANGE: Remove `allAtOnce` option in favor of `delay: 0` or `paste` event BREAKING CHANGE: Make `hover` and `unhover` sync BREAKING CHANGE: Remove `toggleSelectedOptions` in favor of `deselectOptions` BREAKING CHANGE: (Potentially...) improve correctness of all APIs (so we fire some additional events and improve general correctness). This may or may not break your usage depending on whether you relied on our in-correctness 😅 BREAKING CHANGE: `type` now *actually* defaults the `delay` to `0`, so it's not necessarily `async` anymore. It's only async if you pass a `delay`.
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: make several API and implementation improvements
Why: I was going to merge user-event into DOM Testing Library core (read more in testing-library/dom-testing-library#616), but unfortunately hit a ship stopping snag. So instead, I'm backporting my improvements and we're not going to merge the projects at this time.
How: ugh, way too much to describe 😬
Checklist: