-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tab): skip elements with visibility:hidden
#797
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d43575:
|
30f1c77
to
0d43575
Compare
Codecov Report
@@ Coverage Diff @@
## main #797 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 1005 1007 +2
Branches 408 405 -3
=========================================
+ Hits 1005 1007 +2
Continue to review full report at Codecov.
|
visibility:hidden
when tabvisibility:hidden
Thanks a lot for your contribution ❤️ I'm not sure yet if it's worth the merge conflict with v14.0.0-beta. We'll drop support for |
It'll be nice if this issue can be fixed on I can make another PR to |
I've merged the other PR. Would you share why you expect the migration to be put on hold for a while? |
🤔 We have to make tests using I'll close this PR. |
What:
Calling
userEvent.tab
focuses on element withvisibility: hidden
, which is not expected.Why:
It breaks use cases related to
visibility:hidden
anduserEvent.tab
How:
It is fixed by checking whether the target element has style
visibility: hidden
.Checklist: