Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Replace default behavior as part of the central event dispatching.
Why:
The order of events for
userEvent.upload
was incorrect.When clicking the
<input type="file"/>
element in the browser:mousedown
blur
event on the element.input
andchange
event.focus
event on the element.Event handlers on the
click
event can prevent opening the file dialog in the browser.The previous implementation did not honor
Event.defaultPrevented
.How:
Implement default behavior as plugins to the central
dispatchUIEvent
introduced in #838 .If a default behavior is implemented by this library, the default behavior implemented by the DOM implementation is disabled per
event.preventDefault()
.Then
event.defaultPrevented
andevent.preventDefault()
are replaced so that event handlers can use them as usual.Checklist: