fix: missing optional parameter for emitted (#276)

testing-library · Jul 16, 2022 · 6dd4847 · 6dd4847
1 parent 20ceb25
commit 6dd4847
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/src/__tests__/form.js b/src/__tests__/form.js
@@ -62,6 +62,6 @@ test('Review form submits', async () => {
 
   // Assert the right event has been emitted.
   expect(emitted()).toHaveProperty('submit')
-  expect(emitted().submit[0][0]).toMatchObject(fakeReview)
+  expect(emitted('submit')[0][0]).toMatchObject(fakeReview)
   expect(console.warn).not.toHaveBeenCalled()
 })
diff --git a/src/__tests__/user-event.js b/src/__tests__/user-event.js
@@ -53,7 +53,7 @@ test('User events in a form', async () => {
   expect(submitButton).toHaveFocus()
   expect(submitButton).toBeEnabled()
   userEvent.type(submitButton, '{enter}')
-  expect(emitted().submit[0][0]).toMatchObject(fakeReview)
+  expect(emitted('submit')[0][0]).toMatchObject(fakeReview)
 
   expect(console.warn).not.toHaveBeenCalled()
 })

diff --git a/src/render.js b/src/render.js
@@ -45,7 +45,7 @@ Check out the test examples on GitHub for further details.`)
         : console.log(prettyDOM(el, maxLength, options)),
     unmount: () => wrapper.unmount(),
     html: () => wrapper.html(),
-    emitted: () => wrapper.emitted(),
+    emitted: name => wrapper.emitted(name),
     rerender: props => wrapper.setProps(props),
     ...getQueriesForElement(baseElement),
   }

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -24,6 +24,7 @@ export interface RenderResult extends BoundFunctions<typeof queries> {
   unmount(): void
   html(): string
   emitted<T = unknown>(): Record<string, T[]>
+  emitted<T = unknown>(name?: string): T[]
   rerender(props: object): Promise<void>
 }
 

diff --git a/types/index.test-d.ts b/types/index.test-d.ts
@@ -86,6 +86,7 @@ export function testOptions() {
 export function testEmitted() {
   const {emitted} = render(SomeComponent)
   expectType<unknown[]>(emitted().foo)
+  expectType<unknown[]>(emitted('foo'))
 }
 
 /*