Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to new Discord and several other improvements on Readme #148

Merged
merged 9 commits into from
Jun 22, 2020
Merged

Link to new Discord and several other improvements on Readme #148

merged 9 commits into from
Jun 22, 2020

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Jun 20, 2020

  • Update basic example to use screen
  • Add jest-dom and byRole suggestions
  • Link to new Discord server
  • Add Guiding Principle section
  • Add links to issuess

@codecov
Copy link

codecov bot commented Jun 20, 2020 •
edited
Loading

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           70        70           
  Branches        13        13           
=========================================
  Hits            70        70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5f724...71620ed. Read the comment docs.

@afontcu afontcu changed the title Update Readme Link to new Discord and several other improvements on Readme Jun 20, 2020
@afontcu afontcu mentioned this pull request Jun 21, 2020
Merged
nickserv
nickserv requested changes Jun 21, 2020
View reviewed changes
Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One less PR to file for migrating from Spectrum to Discord.

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@afontcu @nickserv
Update .github/ISSUE_TEMPLATE/bug_report.md
71620ed 
Co-authored-by: Nick McCurdy <nick@nickmccurdy.com>
@afontcu afontcu merged commit af30961 into master Jun 22, 2020
@afontcu afontcu deleted the update-readme branch June 22, 2020 07:40
@afontcu
Copy link
Member Author

afontcu commented Sep 28, 2020

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickserv nickserv nickserv approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afontcu @nickserv